kvikshaug commented 5 years ago

Always store uploaded models to disk and log their filename (not just on load failure)
Place the models in /models/ subdir
Store models along with the report in the task results

This should help with being able to always find the original model when issues occur on various unexpected places in the pipeline, and hence debug those issues.

codecov-io commented 5 years ago

Codecov Report

Merging #13 into master will decrease coverage by 0.62%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage      69%   68.38%   -0.63%     
==========================================
  Files          12       12              
  Lines         271      272       +1     
==========================================
- Hits          187      186       -1     
- Misses         84       86       +2

Impacted Files	Coverage Δ
src/memote_webservice/resources/submit.py	`65.88% <0%> (+1.1%)`	:arrow_up:
src/memote_webservice/resources/report.py	`41.37% <0%> (-4.78%)`	:arrow_down:
src/memote_webservice/tasks.py	`45.45% <0%> (-4.55%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 124ea72...7aaf5df. Read the comment docs.

Midnighter commented 5 years ago

I don't disagree with this but I think our users need to be informed of this change.

kvikshaug commented 5 years ago

I don't disagree with this but I think our users need to be informed of this change.

Good point - added a suggestion in https://github.com/DD-DeCaF/memote-service-frontend/pull/20

DD-DeCaF / memote-webservice

Always store uploaded models #13

Codecov Report