DD-DeCaF / metabolica-ui-pathways

Frontend for running heterologous pathways predictions
Apache License 2.0
0 stars 0 forks source link

refactor/escher service refactor #7

Closed matyasfodor closed 7 years ago

matyasfodor commented 7 years ago

what changes and why?

We decided to port this algorithm to javascript to be able to use it in different components.

This PR also contains a general cleanup: I added karma tests, wrote some unit tests that helped refactoring, fixed whitespaces here and there.

Please note the lack of typings in most of the new functionality: The reasons I decided to leave that out is that the actual algorithm will be ported to Escher, which has no TS set up (although I find it a brilliant idea to add it there). And also the project lacks types in general, and it seemed like a lot of effort.