Closed kvikshaug closed 6 years ago
Merging #111 into caffeine will decrease coverage by
0.14%
. The diff coverage is77.14%
.
@@ Coverage Diff @@
## caffeine #111 +/- ##
============================================
- Coverage 77.2% 77.06% -0.15%
============================================
Files 19 19
Lines 623 606 -17
============================================
- Hits 481 467 -14
+ Misses 142 139 -3
Impacted Files | Coverage Δ | |
---|---|---|
src/model/settings.py | 100% <100%> (ø) |
:arrow_up: |
src/model/adapter.py | 64.78% <66.66%> (-0.25%) |
:arrow_down: |
src/model/driven.py | 93.54% <66.66%> (-0.11%) |
:arrow_down: |
src/model/app.py | 89.28% <75%> (-3.82%) |
:arrow_down: |
src/model/storage.py | 81.25% <77.77%> (-14.91%) |
:arrow_down: |
src/model/resources.py | 69.69% <78.12%> (+2.19%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 86b2457...bb430c7. Read the comment docs.
@Midnighter thanks for the comments, I've added the missing docstrings and followed up on some of the nice-to-haves. The latest rebase should fix the Travis build for the new base image. Is this g2g?
tests/data
for use during testingsrc/tools/update_models.py
should probably be moved to the model storage serviceNote: The travis build seems to fail because the base docker image (
biosustain/cameo-solvers
) is gone, but apart from that QA succeeds locally.