search

DD-DeCaF / simulations

Model service which takes care of adjusting model according to incoming messages and returns information such as fluxes, theoretical maximum yields, etc
Apache License 2.0
0 stars 1 forks source link

Fix local #134

Closed Midnighter closed 5 years ago

Midnighter commented 5 years ago

Small changes to make local development outside the docker environment easier.

codecov-io commented 5 years ago

Codecov Report

Merging #134 into devel will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            devel    #134      +/-   ##
=========================================
+ Coverage   74.67%   74.7%   +0.03%     
=========================================
  Files          20      20              
  Lines         758     759       +1     
=========================================
+ Hits          566     567       +1     
  Misses        192     192
Impacted Files Coverage Δ
src/model/modeling/adapter.py 69.64% <100%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7898b4...60ddba0. Read the comment docs.

Midnighter commented 5 years ago

Maybe it's not something we should merge but it was impossible for me to import the module in other code due to different working directory and data loading from relative path on import.

kvikshaug commented 5 years ago

Ok, I'm fine with the other changes but we should keep the data file where it is.