search

DD-DeCaF / simulations

Model service which takes care of adjusting model according to incoming messages and returns information such as fluxes, theoretical maximum yields, etc
Apache License 2.0
0 stars 1 forks source link

refactor: compare lower case gene names #135

Closed Midnighter closed 5 years ago

Midnighter commented 5 years ago

My apologies for wrapping too many changes into a single commit.

codecov-io commented 5 years ago

Codecov Report

Merging #135 into devel will increase coverage by 0.13%. The diff coverage is 38.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##            devel    #135      +/-   ##
=========================================
+ Coverage   74.67%   74.8%   +0.13%     
=========================================
  Files          20      20              
  Lines         758     766       +8     
=========================================
+ Hits          566     573       +7     
- Misses        192     193       +1
Impacted Files Coverage Δ
src/simulations/modeling/adapter.py 70.28% <38.23%> (+0.82%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5185147...8f2347e. Read the comment docs.

Midnighter commented 5 years ago

I realize I have some disagreements with PEP8 when it comes to short vs long try blocks :(

Is that part of pep8? For me it just seems that one should isolate a try block to the parts one actually expects to fail with the specified error.