DD-DeCaF / simulations

Model service which takes care of adjusting model according to incoming messages and returns information such as fluxes, theoretical maximum yields, etc
Apache License 2.0
0 stars 1 forks source link

fix: ensure feasible simulations of ecModels #156

Closed BenjaSanchez closed 4 years ago

BenjaSanchez commented 4 years ago

Hopefully closes DD-DeCaF/scrum#1217

Add a 5% to the minimal growth required by the flexibilization algorithm, to ensure simulations will work later on regardless of solver approximations.

codecov-io commented 4 years ago

Codecov Report

Merging #156 into devel will increase coverage by 0.28%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            devel    #156      +/-   ##
=========================================
+ Coverage   75.52%   75.8%   +0.28%     
=========================================
  Files          20      21       +1     
  Lines         907     959      +52     
=========================================
+ Hits          685     727      +42     
- Misses        222     232      +10
Impacted Files Coverage Δ
src/simulations/modeling/driven.py 87.7% <100%> (+0.1%) :arrow_up:
src/simulations/resources.py 76.4% <0%> (-7.81%) :arrow_down:
src/simulations/schemas.py 100% <0%> (ø) :arrow_up:
src/simulations/modeling/community.py 96.87% <0%> (ø)
src/simulations/storage.py 84.31% <0%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b838838...40a52b2. Read the comment docs.

ChristianLieven commented 4 years ago

Stellar Job 🌟