search

DD-DeCaF / upload-legacy

uploading data to dd-decaf
Apache License 2.0
1 stars 1 forks source link

Feat/fluxes #18

Closed hredestig closed 7 years ago

hredestig commented 7 years ago
codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (devel@88e4db7). Click here to learn what that means. The diff coverage is 50.64%.

Impacted file tree graph

@@           Coverage Diff            @@
##             devel      #18   +/-   ##
========================================
  Coverage         ?   48.65%           
========================================
  Files            ?        7           
  Lines            ?      559           
  Branches         ?        0           
========================================
  Hits             ?      272           
  Misses           ?      287           
  Partials         ?        0
Impacted Files Coverage Δ
upload/app.py 0% <0%> (ø)
upload/tests/test_inspection.py 100% <100%> (ø)
upload/settings.py 100% <100%> (ø)
upload/checks.py 57.35% <40%> (ø)
upload/upload.py 52.12% <40.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88e4db7...bcd215c. Read the comment docs.

hredestig commented 7 years ago

good point on using one instead of first, fixed

hredestig commented 7 years ago

Thanks for the review, I need to release these fixes so will go ahead and merge, please raise issue if there was still something left to do

Midnighter commented 7 years ago

Don't think it's worth creating issues but two points we should keep in the back of our heads:

  1. The iloop.Model.one method may raise NoResultFound or MultipleResultsFound (not sure if/how those exceptions are wrapped by Potion). We may need to catch those exceptions if they bubble up to the frontend somehow.
  2. Using the namedtuple for the PROJECT_OBJECT is a nice way of going about but it's also the perfect use-case for a mocked instance. Might consider using factoryboy in future.