Sockperf can't be compiled in Debug/Release 32/64 bit in Windows

[GoogleCodeExporter]

What steps will reproduce the problem?
1. When compiling sockperf in Windows in:

    * 64 bit Debug
    * 32 bit Debug
    * 32 bit Release

There is a linkage problem.

The following commit will fix the problem:

Author: Dotan Barak <dotanb@dev.mellanox.co.il>
Date:   Wed Nov 6 14:49:06 2013 +0200

    Add missing libraries when compiling sockperf in Windows

    Add the missing libraries when compiling sockperf in Windows for the following:
    * 64 bit Debug
    * 32 bit Debug
    * 32 bit Release

    Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>

diff --git a/win/project/sockperf.vcxproj b/win/project/sockperf.vcxproj
index 82a2bdf..7cd9d82 100644
--- a/win/project/sockperf.vcxproj
+++ b/win/project/sockperf.vcxproj
@@ -90,6 +90,7 @@
     <Link>
       <SubSystem>Console</SubSystem>
       <GenerateDebugInformation>true</GenerateDebugInformation>
+      
<AdditionalDependencies>Ws2_32.lib;Dbghelp.lib;%(AdditionalDependencies)</Additi
onalDependencies>^M
     </Link>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
@@ -103,6 +104,7 @@
     <Link>
       <SubSystem>Console</SubSystem>
       <GenerateDebugInformation>true</GenerateDebugInformation>
+      
<AdditionalDependencies>Ws2_32.lib;Dbghelp.lib;%(AdditionalDependencies)</Additi
onalDependencies>^M
     </Link>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
@@ -120,7 +122,7 @@
       <GenerateDebugInformation>true</GenerateDebugInformation>
       <EnableCOMDATFolding>true</EnableCOMDATFolding>
       <OptimizeReferences>true</OptimizeReferences>
-      <AdditionalDependencies>Ws2_32.lib, User32.lib, 
Dbghelp.lib</AdditionalDependencies>
+      <AdditionalDependencies>Ws2_32.lib;Dbghelp.lib</AdditionalDependencies>^M
     </Link>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
@@ -178,4 +180,4 @@
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <ImportGroup Label="ExtensionTargets">
   </ImportGroup>
-</Project>
\ No newline at end of file
+</Project>^M

Original issue reported on code.google.com by dot...@dev.mellanox.co.il on 6 Nov 2013 at 1:18

[GoogleCodeExporter]

Original comment by avne...@gmail.com on 6 Nov 2013 at 1:28

• Changed state: Accepted
• Added labels: Pjm-Visited
• Removed labels: Pjm-New

[GoogleCodeExporter]

fixed in r235

Original comment by orkmella...@gmail.com on 6 Nov 2013 at 1:55

• Changed state: Fixed