Method BSTIterative::remove

[samuelsoder]

The implementation of Binary Search Tree (iterative) remove method in src/main/java/com/thealgorithms/datastructures/trees/BSTIterative.java has reported cyclomatic complexity 13 by lizard.

Part 1 steps:

• [x] Manual calculation of cyclomatic complexity @chubretovic
• [x] Manual calculation of cyclomatic complexity @charmed-quark

Part 2 steps:

• [ ] Instrument code coverage manually (in a new branch called something like issue<No>/manual-instrument)
• [ ] Save the result of manual and automatic instrumentation, either in this issue by screenshot or in the branch and link to it.
• [ ] Add tests to improve code coverage (on a different branch than before, called something like issue<No>/increase-coverage). Assignment PDF gives more detailed steps on what steps should be taken to identify types of tests to add etc.
• [ ] Create a plan or draft for refactoring the function. A clear description is required to pass the assignment.

[chubretovic]

If = 9 || = 0 && = 1 While = 2 For = 0 Return = 0

M = 12 - 0 + 2 = 14

[charmed-quark]

I've counted all if, else if, and else, as well as && and while, in total 17. For exit points I considered all the possible places where the function would stop running (no returns because it is void). These points are line 137 (if the if statement evaluates to false), line 174, line 177, and line 179, in total 4.

This gives 17 - 4 + 2 = 15.

I also tried not counting else which gives a result of 10. Neither agrees with lizard's calculation.