search

DD2480-Group-10 / manim

A community-maintained Python framework for creating mathematical animations.
https://www.manim.community
MIT License
1 stars 0 forks source link

Contributions to ManimCommunity/manim? #13

Open behackl opened 2 years ago

behackl commented 2 years ago

Hej allihopa från Uppsala! :-)

We (as in some of us over at ManimCommunity/manim) have been seeing your activity here and were wondering: do you intend to submit the changes you have made here back to the main repository eventually? In case you do so, please keep in mind that submitting a very large set of changes (sometimes referred to as patch bomb) usually is somewhat problematic, as you'll need at least one of our core developers to review your changes. We have had other large PRs with good intentions (e.g., https://github.com/ManimCommunity/manim/pull/2417) that simply died a more or less silent death because they were practically unreviewable.

And of course, in case you have any questions or concerns, please don't hesitate to get in touch with us! :-)

(Feel free to simply close this issue, I just thought it would be the easiest way to get in touch with you.)

BrorSebastianSjovald commented 2 years ago

We are done with our changes! Just waiting for my latest PR to be reviewed here. After that we plan to submit a PR to the main repo.

Our changes are targeted against solving the issue ManimCommunity#2451. It mostly affects utils/color.py and the usage of some deprecated functions.

Should we try to divide our changes into smaller PRs?

Darylgolden commented 2 years ago

I've looked at the changes again, and assuming you are planning to PR refactor/color I think it's actually not too complicated to be in a single PR. I should say that deprecation warnings should be done using our decorators instead. I'd also say that the color conversion functions are meant to be internally used (the distinction between internal and user-facing functions is not very clear in Manim yet, unfortunately), so don't really need a deprecation warning. Thanks for the work you've done so far, we look forward to seeing your PR!

BrorSebastianSjovald commented 2 years ago

The plan is to PR refactor/color but it now includes changes to other files than color.py to call on the external colourmodule. I will add the deprecated decorator instead of using warnings.

After that I will submit a PR so we can discuss what should change there!