search

DDMAL / MEI2Volpiano

An MEI to Volpiano converter for CWMN or Neume MEI files.
MIT License
0 stars 0 forks source link

Use a dedicated python xml library instead of line-by-line #4

Closed napulen closed 3 years ago

napulen commented 3 years ago

Given how complex MEI files can get, it is not robust to parse them line by line.

The use of an xml parser is much better for this purpose.

I recommend looking into the official python tool for this: https://docs.python.org/3/library/xml.etree.elementtree.html

Either that or the defusedxml alternative. I don't have security concerns for this code (the main motivation for defusedxml), given that we plan to use it with in-house xml files only, so I think the official one is a better choice.

kemalkongar commented 3 years ago

Given the issues with libmei we'll go with ET for now!

napulen commented 3 years ago

Go for it

kemalkongar commented 3 years ago

Issue can be closed per the latest push into master.