DDMAL / MEI2Volpiano

An MEI to Volpiano converter for CWMN or Neume MEI files.
MIT License
0 stars 0 forks source link

Code include code coverage #42

Closed napulen closed 3 years ago

napulen commented 3 years ago

It'd be relatively easy to include code coverage of the tests in this repository.

I have been trying the coverage Python package with the codecov service, integrated via github-actions. It's very simple to set up. Something like this on the gh-actions workflow suffices:

    - name: Test with pytest and coverage
      run: |
        coverage run -m pytest
    - name: Upload coverage to codecov
      uses: codecov/codecov-action@v1
      with:
        token: ${{ secrets.CODECOV_UPLOAD_TOKEN }}
        fail_ci_if_error: true
        verbose: true

coverage needs to be included in the requirements/dependencies

napulen commented 3 years ago

In this case, the token is not necessary, because it is only necessary for private repositories.

raviraina commented 3 years ago

@napulen made the respective changes and receive the following about halfway through coverage:

{'detail': ErrorDetail(string='Could not find a repository, try using upload token', code='not_found')}

napulen commented 3 years ago

The token needs to be added via the settings of the repo.

napulen commented 3 years ago

I'll integrate this repo on codecov and come back to this when it's done, maybe it will fix itself when I change the settings.

napulen commented 3 years ago

Thanks for adding the changes

napulen commented 3 years ago

I have activated this repo within codecov now. Code coverage should work after the next commit.

napulen commented 3 years ago

If not, we can add the token. The documentation is sometimes contradictory about policies for public repos.

kemalkongar commented 3 years ago

Wonderful. Would you like me to create a force build in dev and PR into main?

napulen commented 3 years ago

If token is needed, I already put it in the settings of the repo. We'd need to add something like this:

      with:
        token: ${{ secrets.CODECOV_TOKEN }}
napulen commented 3 years ago

Sure, let's try

raviraina commented 3 years ago

Completed with #47