When deleting a clef, the clef only disappears after another action is performed

DDMAL / Neon

A web-based MEI neume editor.

https://ddmal.music.mcgill.ca/Neon

MIT License

25 stars 9 forks source link

When deleting a clef, the clef only disappears after another action is performed #1157

Closed JoyfulGen closed 11 months ago

JoyfulGen commented 11 months ago

Thank you @PhoebeDM for finding this one! It started happening sometime last week, sources tell me. To reproduce:

Select a clef in a straight-outta-OMR file.
Delete the clef (with keyboard shortcut or by clicking on the button); nothing happens.
Perform any other action.
The clef disappears.

It seems like Neon doesn't register the deletion until another action is performed, because if I delete a clef and undo my action, Neon tells me there are no actions to undo.

yinanazhou commented 11 months ago

Hi @JoyfulGen I've pushed the changes :)

JoyfulGen commented 11 months ago

@yinanazhou fixed! Issue can be closed now, as far as I'm concerned :)