DDMAL / Rodan

:dragon_face: A web-based workflow engine.
https://rodan2.simssa.ca/
45 stars 13 forks source link

GPU-celery Dockerfile python version update needed #1185

Open homework36 opened 1 week ago

homework36 commented 1 week ago

I still don't understand how Docker Hub build test works (as part of CI). For example, my latest PR #1182 successfully passes all checks but after it's merged into develop, the Docker Hub webhook build fails. I also don't know when the image build will be triggered.

Screenshot 2024-07-02 at 10 32 23 AM

If we click on "details" we get

"error": "Our service is temporarily unavailable. We'll be back soon!"

Update: We do have new images built on Docker Hub with tag nightly as expected, and I have used those new images to test locally and then update staging. There seems no problem. The Docker Hub image build failure happens to the webhook, which I believe is the test. According to line 38 in hook.py, we get ddmal/docker-webhook:rodan-pass-{SOMETHING} after we can successfully push gpu-celery, postgre, nginx, and iipsrv images. In fact, we do miss newly built images for those on our Docker Hub.

homework36 commented 6 days ago

Error message for gpu-celery build failure on Docker Hub for recent PR (link):

This script does not work on Python 3.7. The minimum supported Python version is 3.8.

We need to update versions for gpu-celery in the relevant Dockerfile. Because we don't update most GPU jobs that frequently, there is probably some time for us to test and update.