DDMAL / Rodan

:dragon_face: A web-based workflow engine.
https://rodan2.simssa.ca/
46 stars 13 forks source link

Despeckling: The preview we see in the interface does not correspond at all to what the job does on the server. #186

Closed deepanjanroy closed 9 years ago

deepanjanroy commented 11 years ago

I believe the problem is that cc_size is a size and therefore must be scaled properly. A linear scaling of the cc_size has been added to rdn_despeckle in rodan_plugins (similar to how we scale coordinates in rdn_crop), but it still works very poorly.

deepanjanroy commented 11 years ago

This problem is non-trivial. We will have to rethink how it can to be possible to do interactive despeckling reliably on the client, especially with large images. I'm changing the priority level to low as the automatic despeckling seems to be working all right at the moment.

This will also involve making a new JS interface - the current interface will not work. It is risky to despeckle a large thumbnail version of the image and then scale the cc_size value to apply it to the original. It will be cool if we can come up with a dive-like solution.

ahankinson commented 11 years ago

Since despeckling is a global operation, we can do it in a smaller "window" on the full image. So, create a 400x400 area of the full image, and then have the interactive despeckle work on that. Clicking and dragging on the window will move the image around, so you can see different parts of the image.

We did this in the past with binarisation.

On 2013-07-30, at 1:05 AM, DeepanjanRoy notifications@github.com wrote:

This problem is non-trivial. We will have to rethink how it can to be possible to do interactive despeckling reliably on the client, especially with large images. I'm changing the priority level to low as the automatic despeckling seems to be working all right at the moment.

This will also involve making a new JS interface - the current interface will not work. It is risky to despeckle a large thumbnail version of the image and then scale the cc_size value to apply it to the original. It will be cool if we can come up with a dive-like solution.

— Reply to this email directly or view it on GitHub.