Closed ahankinson closed 10 years ago
You said that I could close this, but Rodan doesn't yet have an interactive binarize job so I don't think it should be closed.
Deep, please take over from here. Copy RKBinarize and index-new.html from js-image-suite/binarization-app into Frameworks/resources/RodanKit and rodan/templates/jobs respectively and make an interactive job for binarise.
Andrew, Deep is having to copy a whole bunch of Csrf code (which he used to get Neon to work,) because we stopped using form submission on these apps. Example: rodan/templates/jobs/rotate.html. I just want you to be aware of this because we are creating a 'standard' for RodanKit, and I don't think you were aware that we would need this Csrf patchwork.
This will apply to despeckle as well (issue #276.)
Please assign to Deep if this is fine.
OK, thanks.
If it helps, there is already CSRF functionality built into Rodan:
https://github.com/DDMAL/Rodan/blob/master/client/Rodan/AppController.j#L515
This is why we don't need to constantly be doing CSRF stuff with the Cappuccino classes, since everything that goes through Ratatosk gets an X-CSRF Token header just before it goes off to the server.
You could probably figure out a way to bridge Cappuccino and JavaScript and then send that along when you instantiate an RK* job. Does that help?
Fixed in RodanClient
RKBinarise is a re-write of the previous binarisation module.
https://github.com/DDMAL/js-image-suite/blob/master/binarization-app/static/js/RKBinarise.js
Brink is currently implemented but broken (and not that important, in my opinion). The index-new.html template file shows an example of how to instantiate it.
The dependency on Kinetic.js has been removed.
This version does not need preview images and should operate fairly quickly on largish images. More testing needed here.