search

DDMAL / RodanClient-old

Client for DDMAL Rodan software suite
0 stars 0 forks source link

Test Workflow running too many times #20

Closed timwilfong closed 10 years ago

timwilfong commented 10 years ago

Lately, when I have pressed the test workflow button, it has been doing two runs instead of one. However, I just tried running a test page and got error messages, and after Ryan restarted both Rodan and Celery, and in the mean time, there are 205 runs of this test page. Also, they all have the status "Not Running".

See St. Gallen 390 (lower-res), Results, Niblack with Lyric Extraction, the runs from Monday, May 26, 2014.

timwilfong commented 10 years ago

Also, here is my consul output:

2014-05-26 12:07:24.813 Cappuccino [info]: makeRequest: <WLRemoteAction 788 PATCH http://rodan.simssa.ca/workflowjob/8c5203180e0c4bc0a45742a6890c6c7b/ [object Object]> Objective-J.js:515 2014-05-26 12:07:24.891 Cappuccino [info]: makeRequest: <WLRemoteAction 789 PATCH http://rodan.simssa.ca/workflowjob/5da2088e4a354ac6989aa9aba81de0da/ [object Object]> Objective-J.js:515 2014-05-26 12:07:24.967 Cappuccino [info]: makeRequest: <WLRemoteAction 790 PATCH http://rodan.simssa.ca/workflowjob/bfc8980900c3446f88ac18bba13f0e92/ [object Object]> Objective-J.js:515 2014-05-26 12:07:25.042 Cappuccino [info]: makeRequest: <WLRemoteAction 791 POST /workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ [object Object]> Objective-J.js:515 POST http://rodan.simssa.ca/workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ 500 (INTERNAL SERVER ERROR) Objective-J.js:910 2014-05-26 12:07:26.012 Cappuccino [error]: Received error code 500. Objective-J.js:515 2014-05-26 12:07:26.013 Cappuccino [error]: Unable to decode response (status code 500). Objective-J.js:515 2014-05-26 12:07:26.016 Cappuccino [error]: Action failed <WLRemoteAction 791 POST /workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ [object Object]> Objective-J.js:515 2014-05-26 12:07:36.016 Cappuccino [info]: makeRequest: <WLRemoteAction 791 POST /workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ [object Object]> Objective-J.js:515 POST http://rodan.simssa.ca/workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ 500 (INTERNAL SERVER ERROR) Objective-J.js:910 2014-05-26 12:07:36.967 Cappuccino [error]: Received error code 500. Objective-J.js:515 2014-05-26 12:07:36.968 Cappuccino [error]: Unable to decode response (status code 500). Objective-J.js:515 2014-05-26 12:07:36.968 Cappuccino [error]: Action failed <WLRemoteAction 791 POST /workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ [object Object]> Objective-J.js:515 2014-05-26 12:07:46.968 Cappuccino [info]: makeRequest: <WLRemoteAction 791 POST /workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ [object Object]> Objective-J.js:515 POST http://rodan.simssa.ca/workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ 500 (INTERNAL SERVER ERROR) Objective-J.js:910 2014-05-26 12:07:47.763 Cappuccino [error]: Received error code 500. Objective-J.js:515 2014-05-26 12:07:47.764 Cappuccino [error]: Unable to decode response (status code 500). Objective-J.js:515 2014-05-26 12:07:47.764 Cappuccino [error]: Action failed <WLRemoteAction 791 POST /workflowruns/?test=true&page_id=http://rodan.simssa.ca/page/2b9e4f6610004fb8aba7833565011443/ [object Object]> Objective-J.js:515

mrbannon commented 10 years ago

Something in the Objective-J is trying to resend a POST if it receives 500.

mrbannon commented 10 years ago

Actually, it has to do with Ratatosk.

The 500 is generated for some reason on the server (doesn't really matter why). When Ratatosk gets this 500, it never makes it to https://github.com/wireload/Ratatosk/blob/master/WLRemoteLink.j#L275.

When a later request is made on the same WLRemoteLink (GET, POST, WHATEVER), it obviously tries the first one it sees in the queue. So, it tries the POST again.

I think a delegate has to be set up for receiving the error (or maybe a setting has to be adjusted when making the request). Else, this is a bug in Ratatosk

ahankinson commented 10 years ago

Does it make it to:

https://github.com/wireload/Ratatosk/blob/master/WLRemoteLink.j#L240