DDMAL / VIM

The Virtual Instrument Museum website repository
MIT License
1 stars 2 forks source link

should the 'French site' default to french for everything? #169

Open annamorphism opened 6 days ago

annamorphism commented 6 days ago

I think it's a little weird that when you open the site and click on the French half of the site, the names come up in French but the site itself is still English ("More facets coming", "Instrument list", "showing XXX entries...") I know we have these separate for a reason, but I don't think it would be obvious to a French user why only half the contents look translated. ...

image
dchiller commented 6 days ago

I'm not sure whether this is doable given how things are implemented (I could look more) but I wonder if there's a way to have the "instrument name language" be set to the "site language" automatically where there is overlap, even though the content is coming from different places (google's api vs our database/wikidata)

kunfang98927 commented 19 hours ago

The solution now is:

annamorphism commented 13 hours ago

thanks @kunfang98927 . I guess my question is very particular to what happens when you go from the landing page to the instruments--I think I would expect that after I've hit a button called "commencer" that sets ?language=french, I wouldn't then get to a page where all the buttons (i.e. the site language) are in English again. (I mean, I recognize what we are trying to do here and why these aspects are controlled separately, but I think people would be more likely to expect this to change the "site language"). I like @dchiller 's suggestion, though I don't know if it's feasible...

annamorphism commented 13 hours ago

actually come to think of it, if you ARE looking at the site in French already, the home page looks like this:

image

There's no way of knowing that the left "Commencer" takes you to a French site with English labels.

image

but the right one gets you French with French labels:

image