search

DDMAL / VIM

The Virtual Instrument Museum website repository
MIT License
0 stars 2 forks source link

Add python formatting action #46

Closed dchiller closed 9 months ago

dchiller commented 10 months ago

Adds a GitHub action targeting pull requests that executes a black formatting check to python code.

jacobdgm commented 9 months ago

I don't know enough about GitHub Actions to give an informed appoval of this. None of it looks unreasonable, though.

Question: is GitHub Actions necessary for this, or could git hooks work just as well? I guess GH Actions ensures that code will be Black-conforming even if the developer opening a PR didn't set up their hooks correctly.

dchiller commented 9 months ago

I guess GH Actions ensures that code will be Black-conforming even if the developer opening a PR didn't set up their hooks correctly.

Correct. For now, this is all that's here, but eventually add workflows unit tests, deployment checks, etc.