Update pagination setting

DDMAL / VIM

The Virtual Instrument Museum website repository

MIT License

0 stars 2 forks source link

Update pagination setting #81

Closed kunfang98927 closed 11 months ago

kunfang98927 commented 11 months ago

remove the former setting button and modal
create a new pagination setting similar to Wikidata; three options - view 20/50/100 per page
add "Go to xxx Page"

kunfang98927 commented 11 months ago

I just updated the pagination setting. Maybe the review can be done after the project meeting so it's not rushed.

dchiller commented 11 months ago

This looks great! I have only two comments:

I think it would be better to have "Go to Page XX" rather than "Go To XX Page". It's only European languages, so I'd be curious what other's find, but it looks better to me that way in English and when translated to Spanish and French than the way it currently is.

I wonder if the numbers here could either have more contrast or have some kind of divider ... they run together a bit for me here.

kunfang98927 commented 11 months ago

Thank you for the advice. I'm going to use 'Go to Page XXX'. Maybe I can add vertical lines between page numbers like Wikidata does.

kunfang98927 commented 11 months ago

Have updated the pagination setting. Now it looks like this

dchiller commented 11 months ago

Looks great!