search

DDMAL / jSymbolic2

2nd Version of jSymbolic
29 stars 3 forks source link

Correct unit testing code so that all tests pass #34

Closed codaich closed 7 years ago

codaich commented 7 years ago

Many of the test fails are simply because I've changed the name field valuess of certain features and the order in which features are loaded by FeatureExtractorAccess (I made corresponding changes to some of the test code, but not all). This is lower priority than some of the other issues, but when you have a chance please update the testing code to reflect all the changes I've made (and to make sure the tests all pass in general).

codaich commented 7 years ago

When you have a chance (not highest priority) please also implement unit testing code for features that don't already have it (including ones I've implemented, and including new ones I'm in the process of implementing now).

(Remember that the HTML manual is now the authoritative reference for feature descriptions, not my dissertation, by the way.)

codaich commented 7 years ago

Will also need to rename some of the unit testing methods to match their corresponding renamed features.

codaich commented 7 years ago

I won't be making any further changes in the near future to any of the feature code (all of me of latest changes are included in merge [594be90]), so feel free to proceed on this whenever you have a chance (no big rush, though).

codaich commented 7 years ago

Fixed in series of commits ending with [4dfd302]. Only two tests still fail, relating to two features that are themselves buggy (Melodic Pitch Variety and Parallel Motion).