search

DDMAL / jSymbolic2

2nd Version of jSymbolic
29 stars 3 forks source link

15 files cannot have features extracted from them with jSymbolic2 #42

Closed codaich closed 7 years ago

codaich commented 7 years ago

I just ran a test of all 3,630 of the jSymbolic2 test files using the current jSymbolic2 development commit [5c5db52], and all but the following 15 passed fully:

Please take a look at these 15 files to see whether the problem is with the files or with jSymbolic. I already know that the only problematic MIDI file is actually an empty MIDI file, so this is not jSymbolic's fault, but I haven't looked at the 14 problematic MEI files.

dinamix1 commented 7 years ago

Fixed #42 by commit adafaeff63ee87ca5c875aaf9e61a91406a544ee in jMei2Midi repository. Beethoven and Schumann are both poor mei files. This is confirmed by verovio at http://ddmal.github.io/mei-test-set/complete-examples/Beethoven_op.18.html and http://ddmal.github.io/mei-test-set/complete-examples/Schumann_Op.41.html respectively. Also, similar to the midi file, the multimeasure-rests.mei and the note-head-denominator.mei both contain only rests and therefore generate empty midi files. This can be seen at http://ddmal.github.io/mei-test-set/MEI-test-set/meter.html.

codaich commented 7 years ago

OK, good job. Grace note problem fixed in jMei2Midi commit [bde40f6]. Remaining four problematic files are due to problems in files themselves, not jSymbolic:

Issue closed.