search

DDMAL / linkedmusic-website

website for LinkedMusic Partnership Grant
https://linkedmusic.ca
2 stars 0 forks source link

http and https consistency in jquery imports #13

Closed napulen closed 3 years ago

napulen commented 3 years ago

There are some mixed content errors in the site when importing jquery

image

This is because sometimes the link to jquery is via http instead of https. For example, here:

https://github.com/DDMAL/linkedmusic-website/blob/ec99ab46f5dcaa216a65f5d08247866ee9e6dc6b/_layouts/page_photo_header.html#L15

The site is configured to enforce https, so we should use https in everything, unless it's not possible (e.g., the site doesn't have a valid https certificate).

For this particular error, it's just string replacing all those http -> https

napulen commented 3 years ago

Related to this, because of the mixed content issue, jquery doesn't load sometimes and you get these errors in some pages:

image

The $ not defined it is complaining about is basically the jquery syntax not being recognized (because it wasn't loaded).

emilyhopkins commented 3 years ago

OK, thank you for this! I will go through and fix it.

emilyhopkins commented 3 years ago

I think this is resolved. Here is the site with the console viewer now:

Screen Shot 2021-08-09 at 11 54 34