search

DDMAL / meix.js

Browser-based MEI editor.
4 stars 4 forks source link

Make standalone #3

Closed ahankinson closed 10 years ago

ahankinson commented 10 years ago

The repo should be cleaned up to make this a standalone component:

1) Move the demo file to index.html 2) Remove any references to diva components -- they should be stored in the St. Gall project that uses this component.

ahwitz commented 10 years ago

I didn't understand 2) from what you told me on friday, but that makes a lot more sense now.

Should the Diva plugin stay in a plugins folder here, or should it be moved as well?

ahankinson commented 10 years ago

It should move back to the St. Gall repo too. Basically, make meix the equivalent of Diva. You wouldn't commit the Diva plugin for St. Gall into the Diva repo; you should maintain that same type of separation here as well.

ahwitz commented 10 years ago

I think we're misunderstanding each other, but I think I need to restructure a few things. Is this correct:

-Keep the meiEditorDivaManager.js file in this repo -Make the meiEditor constructor take the json/diva info rather than having it hardcoded -Move diva.html to the st_gall-dev repo -Actually make a constructor in diva.html that takes the st_gall specific info

ahankinson commented 10 years ago
ahwitz commented 10 years ago

Once I restructure the plugins to function like Diva's, they're completely optional - I'm still in favor of leaving the plugin in this repo and letting the user select what they want, like how nodiva.html doesn't have the meiEditorDivaManager.js plugin in its meiEditor constructor, There's also nothing that's native to st. gall specifically in DivaManager, I don't think, so there's no reason not to keep it in a public repo and help promote interconnectivity (BUZZWORDS!) of all our software.

In the end, I'll go with your call, but I really don't think moving it is the right idea.

ahankinson commented 10 years ago

The Diva plugin isn't generic enough -- it's specific to our needs for the St. Gall project, and it's unlikely that anyone will want to do the same kind of thing with their own project, so let's keep it in the St. Gall folder.

ahwitz commented 10 years ago

Think this is closed.

ahankinson commented 10 years ago

:+1: