search

DDMAL / pixel_wrapper

Rodan Pixel.js Wrapper
Other
0 stars 1 forks source link

Pixel.sh script installs incompatible version of gulp #36

Closed EricHanLiu closed 6 years ago

EricHanLiu commented 6 years ago 
gulpInst.start.apply(gulpInst, toRun);
                   ^

TypeError: Cannot read property 'apply' of undefined
    at /usr/local/lib/node_modules/gulp/bin/gulp.js:129:20
    at process._tickCallback (internal/process/next_tick.js:61:11)

Seems like gulp.start in general has been deprecated and that's why there's no documentation about it (see issue)

Might need to change the script to install gulp4 since that's what pixel_wrapper uses to build now (fixed vulnerabilities)

EricHanLiu commented 6 years ago

yeah fixed by forcing script to install gulp@4.0.0, will add to the activate_wrapper.py script since the standalone Pixel.js uses different dependencies

EricHanLiu commented 6 years ago

Fixed in PR #38

EricHanLiu commented 6 years ago

Closing, awaiting PR to be accepted