search

DDMAL / pixel_wrapper

Rodan Pixel.js Wrapper
Other
0 stars 1 forks source link

Fix select region layer issues #40

Closed EricHanLiu closed 6 years ago

EricHanLiu commented 6 years ago

Fixes isuse #39

Reverts background layer generation to iterate over whole page (slower, but more consistent performance and less prone to user-error)

Adds hotkeys to select and deselect whole page (SHIFT+A, ESC respectively)

EricHanLiu commented 6 years ago

For some reason the test

drawing select region then submit to rodan creates progress bar

fails in Travis, despite passing locally. I even increased the timeout before it attempts to find the cancel button because I thought maybe it was too fast in Travis so it didn't find it, but it still fails.

It passes just fine when I run the tests locally, and I can even watch (disabling headless) the tests perform and this specific test does create the progress bar properly.

EricHanLiu commented 6 years ago

@vigliensoni @deepio could one of you take a look and review? I've run tests and the changes don't break anything

EricHanLiu commented 6 years ago

I no longer have write access to this repo?

Would appreciate a merge @deepio or @vigliensoni