search

DDMAL / vida.js

Verovio Image Display Assistant
8 stars 4 forks source link

Bootstrap header with button #25

Open lpugin opened 9 years ago

lpugin commented 9 years ago

Shouldn't we have a navbar for the navigation arrows and toggle button as in the VerovioEditor?

ahwitz commented 9 years ago

You mean like the full black bar on http://cantus.simssa.ca/editor/?ch-sgs-390 ?

lpugin commented 9 years ago

Exactly. And along the same lines, it would be more intuitive to have a refresh button in the Verovio header side that would load the mei file selected in the tabs (instead of having to select "update Verovio" and select the file). Does this make sense?

ahwitz commented 9 years ago

Yup.

lpugin commented 9 years ago

Where does this have to be changed? In vida.js? Sorry, I don't have a good overview of this.

ahwitz commented 9 years ago

Ah, I didn't realize this was an urgent thing. vida will need Bootstrap as a dependency and the necessary design changes, but that's trivial.

To get the "refresh" button... Since it relies on data in the VerovioEditor and since we had intended this to be a standalone project (if you or @ahankinson want it to be combined into the VerovioEditor repo, this could be made easier), what I'd recommend you do is along the lines of...

function refreshButtonHandler(){this.refreshVerovio();}
$("#refresh-button").on('click', refreshButtonHandler);
this.updateRefreshButton = function(newFunction){refreshButtonHandler = newFunction;}

...and then call updateRefreshButton with a reference to a function that gets the text of the active page in meix. Might have to use an events system for it.

Meix sense? (http://instantrimshot.com/) Any better ideas?

lpugin commented 9 years ago

Not that urgent. Most important is the organization of the code. What do you mean by having it combined in the VerovioEditor repo? vida.js?

ahwitz commented 9 years ago

Yeah, make vida.js solely part of the VerovioEditor repo, as I don't know if it'll be used anywhere else. Doing that will allow us to combine the vida functionality into a meix plugin and it might be easier to work with.

lpugin commented 9 years ago

Sounds like a high priority to me. I'll see with @ahankinson