DDOCharPlanner / DDOCharPlannerV4

Dungeons and Dragons Online Character Planner
GNU General Public License v3.0
36 stars 12 forks source link

Resetting skill points #26

Closed DougSK closed 7 years ago

DougSK commented 7 years ago

This is a relatively minor annoyance, but I thought I'd mention it. If you use the Skills screen to spend skill points, then, for example, decide to change leveling order of your multiclass, you have to reset (zero out) skill points first if you want to avoid generating errors. The easy way would seem to be to go into the skills screen and click Reset. However, there's no option to save (Accept) the reset without first spending at least 1 skill point. The Accept button stays grayed out after a Reset. Ought to be a simple fix, I'd think.

(Ideally, it'd be nice if you could re-order your class levels and have them bring their feats, skills, spells, etc with them, but that's a much bigger deal programming-wise).

jonesth3 commented 7 years ago

I think I can add the change for the grayed out button easy enough. By the way thank you for your input. It is nice to hear some comments about the program again. I agree about the re-ordering of the class level and moving things with them as not everything can move as they are dependent on many different things. Would required adding a lot of logic into the program. Easier to let the user do the logic.

DougSK commented 7 years ago

I was active time-to-time on Ron's old forum, but I lost track of you during the move here. Thanks, even more, for being willing to keep this thing usable for those of us who depend on it.

Yeah, I've done programming (only COBOL, but still...). Had an idea how much might go into dragging things with the class levels. Would it be possible to simply void/blank/zero out everything connected to a level when the class for that level changes? Would avoid some tedium (change class, see errors, change class back, wipe feats/skills/spells as necessary, re-change class).

jonesth3 commented 7 years ago

I might just add a button to clear all errors, This way if someone makes a change that caused an error that they did not expect they can fix it, but there is a way for someone to clear the errors with out having to reset the toon the the prior configuration before clearing the errors.

jonesth3 commented 7 years ago

I have fixed the issue for the grayed out accept button, but I am having an issue that I can not get the planner the create an error that it will show me on the main page so that I can program the removal. Can you give me an example. I know that feats can some times be a issue, but those did not pop the red buttons for me for some reason.

DougSK commented 7 years ago

Not sure what you mean. What error are you trying to generate?

The only error to which I referred would come up if you had already spent the skill points for a particular level, then changed classes to one with fewer skill points/level.

DougSK commented 7 years ago

"I might just add a button to clear all errors, This way if someone makes a change that caused an error that they did not expect they can fix it, but there is a way for someone to clear the errors with out having to reset the toon the the prior configuration before clearing the errors."

Also a decent solution. And probably easier to implement.

jonesth3 commented 7 years ago

I have fixed the accept button so it will show it any change happens to the skills window for now. I am toying with the idea of adding a right click on the level to zero out the entire level worth of points spent. What do you think of that idea?

DougSK commented 7 years ago

Love it. And a similar one on the skill name to zero all the points invested?

jonesth3 commented 7 years ago

Yes, started to look into it last night and decided that would be a good thing to do as well. The errors I thought you were talking about were if you change classes mid design you will some times see the level buttons on the main screen turn red and the "Show Err" button will light up. This mainly happens when you have a feat selected that you no longer can have with the new race or class. When you hit the "Show Err" button it will list the errors in the display box. Does not seem to show errors in the skills selection.

DougSK commented 7 years ago

As far as I know, the only error it shows is if you have spent too many skill points for the new class (e.g. you spent 8 skill points as a Rogue and are now Fighter at that level with only 2 spendable). It doesn't seem to check if you've exceeded the new total skill points investable in a particular skill, but I haven't specifically checked that, either.

jonesth3 commented 7 years ago

This is now working in the editing version. Will be ready for the next release. I enabled both right clicking on Level and Skill to clear.