DDOCharPlanner / DDOCharPlannerV4

Dungeons and Dragons Online Character Planner
GNU General Public License v3.0
36 stars 12 forks source link

Client Crashes - I have noticed alot of client crashes randomly when running the program #7

Closed danielg-github closed 6 years ago

Technical-13 commented 7 years ago

When you say client, do you mean the character planner client or your game client? If you mean the character planner, can you give us any system specifications? What else is running when it crashes?

jonesth3 commented 7 years ago

This may be a graphic releasing issue that I had a while back. Only on a smaller scale. Before it was happening on every build. I found that issue but will have to do some more searching to see if I can find an other unreleased graphics causing a memory over run.

danielg-github commented 7 years ago

It will crash the character builder when i go to save a build. It seems to happen with level 30 feats, but not all the time. My machine will then stuff up and the program will be unusable, the pictures and such don't load, like a memory issue. I then have to kill the process and restart it. Sometimes this is not enough. I will loose the ability to use the windows task bar and have to logout or reboot the machine afterwords.

Running windows 10 64bit 16gig ram. Note: Only this program does this, its unfortunate. It must be a memory or code issue. I can send you more info if it will fix it.

I have set the exe to compatibility mode windows 7 to see how it operates.

jonesth3 commented 7 years ago

Thank you for the info it maybe an issue with the save and load. I was using VS2017 today for the first time which has some diagnostic tools I did not know about. The program runs at about 20 bytes most of the time till the save or open screens are used. It may also be an issue with 10 and the openscreen as this was first programed on xp.

jonesth3 commented 7 years ago

I have added new subroutines for vista and above to use the new Common Dialog Box instead of the old GetFileName. I left the GetFileName for the xp users. I hope this helps. It will be in the next build after U35 comes out. If this did not fix the issue please reopen this issue or start a new one.

Thank you for your input. I can not do this with out your help.

danielg-github commented 7 years ago

Hi Just to give you an update i tried the new version U35 and had the same issue. When clicking the save button after about 20 minutes of use the whole program froze and then crashed, I closed down the application by ctrl-alt-delete then task manager as it stopped my task bar from working inside windows. This worked but it was very slow to navigate the task manager and kill the process. I then had to relog/restart my machine to get the task bar working again.

I am running windows 10 64bit with 16gb ram. I will try to set compatibility mode on the shortcut to windows 7 with admin rights and see if there is any change to the issue.

Note: I did not have much else running during the issue, just a you tube video and web browser. ill include some pictures that might help, let me know if you need more details. Hope that helps.

Cheers Dan

capture2

capture

danielg-github commented 7 years ago

Issue also occurred when running windows 7 compatibility mode. now trying xp.

danielg-github commented 7 years ago

Same deal with xp compatibility mode, crashes and slows down my pc and disables the task bar. Only a relog or restart of windows fixes it. After i kill the process.

Only occurs with the Save button, loading has never crashed.

jonesth3 commented 7 years ago

Thank you for your report. I will have to give it some thought and try and figure out when and why it is happening. Any additional info you can give would be helpful. IE does it tend to happen with the same race, class, feats.

danielg-github commented 7 years ago

Just some further updates, the program will crash on its own if left alone. This was in windows xp compatibility mode. Its not just linked to the save button. Maybe its a memory leak.

danielg-github commented 7 years ago

It happens with any race/class/feats on newly created files and older ones from previous versions. With the compatibility mode Windows XP enabled. It just crashes now and doesn't freeze up my machine as i described above.

I am going to try not running compatibility mode and see how i go. Is there any software i can run that can help you pinpoint the issue. such as memory tools etc.

jonesth3 commented 7 years ago

Thank you for your continued input. This is a little new to me as I program as a hobby and not professionally. The things you describe sound like issues I was having on win 7 a while back till I fixed an issues where I was not releasing some graphics and they where called multiple times, but since I found the error of my ways with that issue I have not been having the issues with Win 7 or Win 8.1. I will commonly have the program open all day long even though I am only working on one build a little at a time. I currently do not have a Win 10 machine to test from.

As for a program that would help trace this issue down I am not sure about that. I will have to look into it, other then downloading Visual Studio and compiling the program and running in debug mode. If you want to try that you can as the full code is now on GitHub.

ghost commented 7 years ago

My client has been crashing occasionally too. Just now the feats list stopped scrolling but the sidebar animated, then the pictures disappeared when I tried to manually drag the slider, I tried to save my build but the dialogue box didn't appear (except in my task bar). Then I got the stopped responding notification. I wondered what would happen if I pressed the debug button and visual studio opened and gave me the following: Unhandled exception at 0x0036B302 in DDOCharPlanner.exe: 0xC0000094: Integer division by zero.

I don't know how to use visual studio to debug but hopefully, the error message helps. On Windows 10 Version 10.0.15063 Build 15063

jonesth3 commented 7 years ago

Thank you for the extra information. I am not sure if it will help, but I have not give up hope of fixing this issue. I am thinking this is related to a redraw sequence that does not happen all the time. I have had it happen to me as well, but have never been able the consistently repeat it. I have left this subject open in hopes I will get more in site. One thing I do know is that once the error shows up is that nothing seems to work right afterwards including saving as you found out.

ghost commented 6 years ago

I keep getting crashes also. To add some more detail "I hope" here is vs2017 debug information.

Unhandled exception at 0x6CB98369 (dui70.dll) in DDOCharPlanner.exe: 0xC0000005: Access violation reading location 0x00000004.

ghost commented 6 years ago

This is the line it crashes on. Appears to be a problem with graphics.

dui70.dll!DirectUI::Value::CreateGraphic(unsigned short const ,struct DirectUI::ScaledSIZE,struct HINSTANCE__ ,bool,bool) Unknown Non-user code. Symbols loaded.

jonesth3 commented 6 years ago

I am hoping that the latest update will take care of your issue as well. Please give it a try and let me know if it helped.