search

DDRace / teeworlds

DEPRECATED - Go to https://github.com/ddnet/ddnet instead!
Other
37 stars 15 forks source link

Restricting rcon output to player #233

Open east opened 11 years ago

east commented 11 years ago

Since all chat commands use OUTPUT_LEVEL_STANDARD for printing the output gets displayed in every remote console. Without spamprotection this issue can be used to kick authed players out of the server (https://github.com/DDRace/teeworlds/issues/232). Here I added a functionality to restrict output messages to specific players. This workaround might be ugly but the ddrace command system kinda lacks of design

Tsin commented 11 years ago

i see i have access to merge it but ofcourse i wont because i dont feel like i should touch any of this stuff my goal was about issues and thats all i will do so i dont know why i kind of have full access to this git kind of feels strange maybe its because its not possible to lower the access but ok

about this isse it doesnt matter if is ugly or not its a fix that is needed and nobody from current devs will fix it and this fix is needed also ddrace is planned to be rewritten in near future so it doesnt matter if now some "ugly" code will be added

so guys add it fast ddmax rly needs it

alandball commented 11 years ago

Doesn't console_output_level control this?