Closed usbalbin closed 3 years ago
The tests are passing locally when changing
actix-grants-proc-macro = { path = "proc-macro", optional = true }
in order to depend on the local version of actix-grants-proc-macro
, not sure what to do about that...
in order to depend on the local version of
actix-grants-proc-macro
, not sure what to do about that...
You can read a description of this problem in another PR.
It's easy to solve, you can just add path and leave the version:
actix-grants-proc-macro = { path = "./proc-macro", version = "1", optional = true }
I also have few comments about this approach to solving the problem with Result. I'll write them soon 🙂
Not sure if you want me to fix the rest of the cargo fmt
-related errors
Not sure if you want me to fix the rest of the
cargo fmt
-related errors
Thanks for you contribution! 🚀 You did a great job, soon I will make a merge with minor changes and notify you. I want to add a test with move semantics 🙂
I merged the changes into #5. Thanks again!
Thank you for the awesome crate :)
Description:
Make ?-operator and early returning work as expected in functions with the
#[has_permissions("foo")]
attribute. This simply wraps the function body in a closure with an async block whis is immediately called and awaited. I believe that probably makes this a breaking change?It should probably be noted that I have never played with the implementation of proc macros before...
Checklist:
Closes #3