Fix status bar color issue present post install

DDvO / Duplicate-Contacts-Manager

This Thunderbird add-on searches address book(s) for pairs of matching contact entries. It can automatically delete entries that have equivalent or less information than the other one. Any remaining matches are presented for manual treatment.

http://ddvo.net/DuplicateContactsManager/

22 stars 9 forks source link

Fix status bar color issue present post install #2

Closed stef204 closed 6 years ago

stef204 commented 6 years ago

Great job indeed with this extremely useful and robust extension! One small nitpick: AFTER installing it, all text appearing in the status bar (bottom left corner) is now color red, as opposed to just plain black, no matter what one does, checking emails, reading address book, etc. Disabling extension fixes color, re-enabling it turns it red again. Could you please fix this or explain how to edit the xpi? Please see this screenshot. Thanks.

Duplicate-Contacts-Manager 1.0.5 Thunderbird 60 Linux x64_86

Edit: possibly lines 83-85 in skin/classic/duplicateContactsManager.css which are getting applied "permanently" as opposed to only when one opens the extension screen to use it?

DDvO commented 6 years ago

Thanks for your feedback! I had not noticed so far, but your are right, the extension does some too 'aggressive' coloring. At the moment I am extremely busy, but will try to find some time this weekend to fix this and upload a new version. As you suspect, this can be done by editing the .css file. The effects of the file are always (and correctly) 'permanent', but the scope of the color change needs to be restricted.

DDvO commented 6 years ago

I've produced a new version 1.0.6 this fixes this and any related issues. The key is to prepend the CSS rules by an extension-specific prefix (here: #handleDuplicates-window) that prevents their applicability to other extensions and other parts of Thunderbird. Moreover, the new release fixes several layout issues.