search

DE-CIX / pbgp-parser

PCAP BGP Parser
Other
84 stars 21 forks source link

--progress flag show no effect #28

Closed mwichtlh closed 7 years ago

mwichtlh commented 7 years ago

The --progress flag does not show any effect when parsing BGP pcaps.

thannaske commented 7 years ago

The --progress-Flag were dropped when moving from version 0.1 to 0.2 due to dependency issues. We wanted to reduce the required dependencies as much as we could and therefore we decided to drop this function. Further reason against keeping it were performance issues. To calculate the remaining time we iterated through the whole PCAP file once to count all packets. This approach noticeably increased the runtime of the parser.

Somehow I forgot to remove it from the argument listing; in fact there is actually a bool value set when the flag is used, but no method is using it.

The argument will be dropped from ArgumentParser in next version 0.1.12