Homogenization float32 -> float64 (default)

DEEPDIP-project / CoupledNODE.jl

Apache License 2.0

2 stars 0 forks source link

Homogenization float32 -> float64 (default) #24

Closed luisaforozco closed 3 months ago

luisaforozco commented 3 months ago

Context

Issue #15

In this PR all the float32 were converted to float64 (default float-point type of Julia). At least for the moment we can keep it like this and see in the future if we need to make some changes due to memory issues.

I've run the examples. Closes #15

APJansen commented 3 months ago

Two small comments, otherwise it looks good to merge:

I still see some f0's in the GrayScott example (and GrayScott_alternative).
Did you compare the timings? It didn't get noticably slower?

luisaforozco commented 3 months ago

TODO_02.04-GrayScott_alternative.jl is still in TODO. So I haven't touched it.
Not getting noticeable slower. Also my laptop has a lot of memory and the examples are rather small.