coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 29
- 251 of 276 (90.94%) changed or added relevant lines in 9 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+43.7%) to 89.161%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| app/lib/lda_api.rb | 48 | 49 | 97.96% | ||
| app/lib/bwq_service.rb | 52 | 57 | 91.23% | ||
| app/lib/lda_resource.rb | 80 | 89 | 89.89% | ||
| app/models/compliance_assessment.rb | 16 | 26 | 61.54% | ||
| <!-- | Total: | 251 | 276 | 90.94% | --> |
| Totals | |
|---|---|
| Change from base Build 14: | 43.7% |
| Covered Lines: | 255 |
| Relevant Lines: | 286 |
ijdickinson
Further building out of the application infrastructure. Primarily this task was focussed on creating a skeleton into which we can build both JavaScript and non-JavaScript interaction patterns. In the case of JS, we initialize a VueJS application that will take over the interactive design elements, and show the user an immediate response to e.g. changing the selected bathing water. In the case of non-JS, we will use a standard GDS-style "ask one question at a time" wizard pattern to elicit the design choices from the user, and then show the preview.
The outstanding action from this task is to add an approach to testing the VueJS app that we can run from
rails tests, but I'm going to defer that to a separate task because this PR is long enough already!This PR does also include the wireframe design that @paperclipmonkey mocked up to test the PDF rendering via Chrome headless. I've mostly included that here because it will form the core of the preview user feature, but I expec that most of the code will get absorbed into the workflow stages in due course.