DEFRA / bwq-signage

Bathing water quality signage service
Other
1 stars 3 forks source link

Task/javascript testing #28

Closed ijdickinson closed 6 years ago

ijdickinson commented 6 years ago

Add JavaScript testing to the app setup. Tests run under Jest, using vue-test-utils. This is more about setting up the capability rather than creating extensive tests (but then, we don't have extensive components to test at the moment!)

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 31


Changes Missing Coverage Covered Lines Changed/Added Lines %
app/lib/lda_api.rb 48 49 97.96%
app/lib/bwq_service.rb 52 57 91.23%
app/lib/lda_resource.rb 80 89 89.89%
app/models/compliance_assessment.rb 16 26 61.54%
<!-- Total: 251 276 90.94% -->
Totals Coverage Status
Change from base Build 14: 43.7%
Covered Lines: 255
Relevant Lines: 286

💛 - Coveralls
ijdickinson commented 6 years ago

Need to merge now, to resolve a git conflict