search

DEFRA / ruby-services-team

Guides, info and issue management for the Ruby Services team
Other
1 stars 3 forks source link

Missing translation exposed during email confirmation #12

Closed Cruikshanks closed 5 years ago

Cruikshanks commented 7 years ago

ITSM call 1622959 highlighted a missing translation. From what we can gather a back office user updates the email address against a registration, and this sends an email to the user to confirm the email address.

When the user clicks the link they see the following error.

screenshot

In this particular case because they were trying to update multiple registrations, the user was getting multiple emails and that seemed to prevent the change from taking place, though more investigation would be needed.

In the meantime we need to add the missing translation, only problem is we don't actually understand what is wrong with the password, so don't know what error message to provide.

Translation missing from en.yml

Identified the rest of the content comes from devise.en.yml

The view is app/views/devise/confirmations/new.html.erb

The method that expects there to be a en.errors.messages.password translation is devise_token_error_messages!

Cruikshanks commented 5 years ago

It is our intention to migrate the remaining functionality in the frontend into our new apps.

Hence have moved this across in the spirit of having a single list of issues, but it is not our intention to fix it because of this.

irisfaraway commented 5 years ago

Closing as we've agreed we won't fix this.