Mock calls to OS Places in unit tests

DEFRA / ruby-services-team

Guides, info and issue management for the Ruby Services team

Other

1 stars 3 forks source link

Mock calls to OS Places in unit tests #79

Closed Cruikshanks closed 4 years ago

Cruikshanks commented 9 years ago

Currently the unit tests rely on making actual calls to the OS Places API. As the unit tests are called automatically as part of the build it makes trying to generate a build problematic if you have no internet connection or the OS Places service is affected.

Cruikshanks commented 4 years ago

Replacing the address lookup code with our defra-ruby-address gem https://github.com/DEFRA/waste-carriers-engine/pull/816

Cruikshanks commented 4 years ago

Again sort of related. This replaces all remaining calls with webmock https://github.com/DEFRA/waste-carriers-engine/pull/817

Cruikshanks commented 4 years ago

We're happy now that this issue has been resolved so am closing 😁