search

DEFRA / software-development-standards

Standards and guidance relating to software development in Defra
https://defra.github.io/software-development-standards/
Other
45 stars 17 forks source link

Add guidance on continuous integration (CI) #13

Closed irisfaraway closed 4 years ago

irisfaraway commented 5 years ago

This is an incomplete first pass based on what we have in dst-guides and what we usually do for projects in Bristol. It's still missing a lot (especially around Jenkins and non-GitHub CI) but I wanted to save what I had so far.

dandpclements commented 5 years ago

I agree this needs input from others on what they do - CONTRIBUTIONS NEEDED FROM EVERYBODY PLEASE

Also reading the document it feels like advice and guidance rather than a standard on how we do continuous integration. Again I'd welcome wide views on this point

ben-sagar commented 5 years ago

I'd second @dandpclements comments: I think we can say "use Travis-CI" etc as our standard for all our public repos on GitHub. We need input from the other areas on using Jenkins and Azure DevOps.

Texel22 commented 5 years ago

We currently have Jenkins set up to build automatically once daily. Also to poll TFS every 2 mins, so as soon as I break something - we all know about it :-) However just reading about this in the Jenkins guidance the way we are polling is not the most efficient way of doing this - so depending on if the the standard would go this detailed - possibly not the way to recommend doing it :-) We also use Open cover, Cobertura and Report generator to report on unit test and code coverage - with in these builds on Jenkins. We also have the Jenkins Link Plugin running. Not sure any of this is of any use for this standard though!

irisfaraway commented 5 years ago

Thanks @Qbtron22, that's really helpful to know!

@dandpclements, I agree this doesn't feel much like a standard at the moment – I think probably because I didn't have a broad enough understanding of what all the needs across the department were, so was a bit hesitant to write "Everyone must do X". But I think it's definitely possible for me to tighten up the GitHub public repos bits.

ben-sagar commented 5 years ago

As Iris has left this as a draft, I'm inclined to not merge it in until she can confirm that she doesn't want to make any further changes on it yet.

irisfaraway commented 5 years ago

@bensagar-ea This feels very incomplete to me as it's just from my limited perspective about how teams around me work, but I'm happy for it to be merged in and then iterated upon by other people.