search

DEFRA / sroc-service-team

Guides, info and issue management for the Charging Module Team
Other
0 stars 1 forks source link

Request dependency has been deprecated #1

Closed Cruikshanks closed 3 years ago

Cruikshanks commented 4 years ago

The TCS currently uses the following dependencies

PR #16 got them up to the latest versions. But they were both deprecated in Feb 2020 and no new changes or updates are being made to them.

We need to investigate what they are being used for and what we should be replacing these dependencies with.

StuAA78 commented 4 years ago

TCS uses these solely to send requests to the rules service -- request is the library for making http requests and request-promise-native extends it to add promise support. The SRoC Charging Module API has adopted got as the http request library, which supports promises by default:

https://github.com/DEFRA/sroc-charging-module-api/blob/main/app/services/rules.service.js

Cruikshanks commented 3 years ago

We no longer make calls to the rules service via the charging service. That service is now redundant so this is no longer an issue.