search

DEFRA / sroc-service-team

Guides, info and issue management for the Charging Module Team
Other
0 stars 1 forks source link

Charging module deploys as `development` #18

Closed Cruikshanks closed 3 years ago

Cruikshanks commented 4 years ago

The deployment task definition for the Charging Module API we inherited sets the NODE_ENV to development.

Best practise is to set this to production as some packages rely on this information to govern how they behave. One obvious example is the logger. When set to production it outputs each log message in a single line assuming it will be aggregated or used by tools like AWS Cloudwatch (which we use). When set to anything else it prints each message over multiple lines because it assumes a developer is scanning the output.

Cruikshanks commented 4 years ago

Non-production environments fixed in https://gitlab-dev.aws-int.defra.cloud/sroc/sroc-jenkins/-/merge_requests/23

Just need to sort production. Request sent to web-ops to make it happen.

StuAA78 commented 3 years ago

This relates to the v1 charging-module-api service which has been superseded by the v2 sroc-charging-module-api service and therefore this won't be fixed.