search

DEFRA / sroc-service-team

Guides, info and issue management for the Charging Module Team
Other
0 stars 1 forks source link

Update to mocha from 1.3.0 to 1.11.2 breaks tests #4

Closed Cruikshanks closed 4 years ago

Cruikshanks commented 4 years ago

There is a dependabot PR to update mocha that is currently failing.

/home/travis/build/DEFRA/sroc-tcm-admin/vendor/bundle/ruby/2.4.0/gems/activesupport-5.1.7/lib/active_support/dependencies.rb:292:in `require': cannot load such file -- mocha/mini_test (LoadError)
    from /home/travis/build/DEFRA/sroc-tcm-admin/vendor/bundle/ruby/2.4.0/gems/activesupport-5.1.7/lib/active_support/dependencies.rb:292:in `block in require'
    from /home/travis/build/DEFRA/sroc-tcm-admin/vendor/bundle/ruby/2.4.0/gems/activesupport-5.1.7/lib/active_support/dependencies.rb:258:in `load_dependency'
    from /home/travis/build/DEFRA/sroc-tcm-admin/vendor/bundle/ruby/2.4.0/gems/activesupport-5.1.7/lib/active_support/dependencies.rb:292:in `require'
    from /home/travis/build/DEFRA/sroc-tcm-admin/test/test_helper.rb:16:in `<top (required)>'
    from /home/travis/build/DEFRA/sroc-tcm-admin/test/controllers/exclusion_reasons_controller_test.rb:1:in `require'
    from /home/travis/build/DEFRA/sroc-tcm-admin/test/controllers/exclusion_reasons_controller_test.rb:1:in `<top (required)>'
    from /home/travis/build/DEFRA/sroc-tcm-admin/vendor/bundle/ruby/2.4.0/gems/railties-5.1.7/lib/rails/test_unit/runner.rb:50:in `require'
# ...

We either need to diagnose and fix the issue or lock the version of mocha.

Cruikshanks commented 4 years ago

Fixed in https://github.com/DEFRA/sroc-tcm-admin/pull/341