DEFRA / sroc-service-team

Guides, info and issue management for the Charging Module Team
Other
0 stars 1 forks source link

Apply defra-ruby-style and fix issues #8

Closed Cruikshanks closed 4 years ago

Cruikshanks commented 4 years ago

Currently, we are not linting the TCM within our CI.

This is for 2 reasons

So to get the project up to Defra standard and allow is to start linting changes automatically we first need to implement defra-ruby-style, then fix any issues it highlights.

Cruikshanks commented 4 years ago

Fixed by https://github.com/DEFRA/sroc-tcm-admin/pull/327

We still have some issues to do with things like class and method size recorded in a .ruboco_todo.yml. But almost 5,000 issues and almost a 100 separate cop violations have been resolved.