DEFRA / sroc-service-team

Guides, info and issue management for the Charging Module Team
Other
0 stars 1 forks source link

Unhandled exceptions knock over service #9

Closed Cruikshanks closed 3 years ago

Cruikshanks commented 4 years ago

We recently had an example of an unhandled error knocking over the service. In an AWS environment, this would mean the container would stop and ECS would start up another.

However, we really shouldn't let unhandled exceptions kill our service. We should be handling and logging them and making sure the client gets a proper response.

The unhandled exception that kicked off this issue has been dealt with.

But we need to

Once we have a firm idea of what needs doing we then can ensure the work is tracked and prioritised by the delivery team.

StuAA78 commented 3 years ago

This relates to the v1 charging-module-api service which has been superseded by the v2 sroc-charging-module-api service and therefore this won't be fixed.