Cruikshanks
commented
4 years ago Regards CodeClimate I'm ignoring it because
- it's the frontend and we are working on making it obsolete
- I feel I'm being penalised for just touching the code
- seriously, its the frontend project!
https://eaflood.atlassian.net/browse/RUBY-850
Currently Waste Carriers Frontend has the ability to intercept and play back the details of the last email sent.
This feature is only enabled in our non-production environments and is used as part of our acceptance tests. However our QA @andrewhick has rightly pointed out that the functionality is inconsistent across our services.
Waste Exemptions has it throughout, Waste Carriers only has it in this app, and Flood Risk Activity Exemptions doesn't have it at all. This makes writing and maintaining acceptance tests across the 3 services difficult and inconsistent so we have been asked to resolve the issue.
Rather than duplicate the existing code even more, we have created defra-ruby-email a reusable engine that can be mounted into an application to provide the same functionality.
Having created the gem, this change is the next step; replacing existing functionality with the engine.