JOIN on _attribute output option

DEIB-GECO / GMQL

GMQL - GenoMetric Query Language

http://www.bioinformatics.deib.polimi.it/geco/

Apache License 2.0

18 stars 11 forks source link

JOIN on _attribute output option #101

Closed sunbrn closed 6 years ago

sunbrn commented 6 years ago

When I use RESULT = JOIN(on_attributes: score) DS1 DS2 I get this compilation error:

JOIN operator at line 5: when a condition on distance is not provided, the only possible region builders are LEFT and RIGHT.

Why are other output possibilities precluded? What is the rational behind this? Why don't we allow LEFT_DISTINCT/RIGHT_DISTINCT instead?

Can you help me to understand this @pp86 @akaitoua @OlgaGorlova? Who implemented this choice? Thanks.

pp86 commented 6 years ago

Option such as CONTIG and INTERSECTION are not possible since the two regions may be on different chr/strands.

I allowed at compile level LEFT_DISTINCT/RIGHT_DISTINCT instead. The engine should not have problems.

marcomass commented 6 years ago

@pp86
For conformity with the general use of JOIN, I would add also BOTH; do you agree?

Limiting the control at compiler level requires to implement the same control in any application using the API; wouldn't be better to add the control also at API level?

marcomass commented 6 years ago

@pp86 Please add also BOTH option.

Can the control to prevent using CAT and INT as output options be implemented at API level?