DEIB-GECO / GMQL

GMQL - GenoMetric Query Language
http://www.bioinformatics.deib.polimi.it/geco/
Apache License 2.0
18 stars 11 forks source link

ORDER meta _groupid #107

Closed marcomass closed 6 years ago

marcomass commented 6 years ago

The following example query: D = SELECT(region: chr == chr1) Example_Dataset_1; RES = ORDER(cell_sex, cell; meta_topg: 1; region_order: qvalue, score; region_topg: 2) D; MATERIALIZE RES INTO order_6; adds metadata _order_groupId (besides metadata _order); is it useful? Doesn't suffice the metadata _order to identify the group? (this is a minor, anyway)

Furthermore, in the case of the following query (meta_topp) also the metadata _order_groupId is added, but the metadata _order is not added: D = SELECT(region: chr == chr1) Example_Dataset_1; RES = ORDER(avg_score DESC; meta_topp: 70) D; MATERIALIZE RES INTO order_4; In this case (meta_topp) the metadata attribute _order should be added and the metadata attribute _order_groupId shouldn't be added.

marcomass commented 6 years ago

@pp86 @acanakoglu In the output metadata of ORDER(... meta_topp: ...):

If anything is not clear, please ask.

marcomass commented 6 years ago

@OlgaGorlova Can you fix this issue?

OlgaGorlova commented 6 years ago

@marcomass I have committed my changes. I have used a query like the following one to test it:

DS = SELECT() Test_DS;
RES_topp = ORDER(test ASC; meta_topp: 80) DS;
RES_topg = ORDER(cell, test ASC; meta_topg: 1) DS;
MATERIALIZE RES_topp into order_topp;
MATERIALIZE RES_topg into order_topg;

The testing dataset Test_DS is attached. Let me know if there are any questions.

marcomass commented 6 years ago

@OlgaGorlova cc @andreagulino I tested on cineca where Andrea updated the system, but the issue is still there: in the output metadata RES_topp is still missing the metadata attribute _order (please add it) and is still included the attribute _order_groupId (please remove it)

OlgaGorlova commented 6 years ago

@marcomass I have checked the issue on both - cineca and my local machine. Locally it is working as expected. Maybe cineca is not updated. @andreagulino I pushed my changes to master branch. I am not sure why it is not working on cineca. Do I have to make some changes anywhere else?

marcomass commented 6 years ago

Fixed.