DEIB-GECO / GMQL

GMQL - GenoMetric Query Language
http://www.bioinformatics.deib.polimi.it/geco/
Apache License 2.0
18 stars 11 forks source link

Fix calculation of AVERAGE when null values are present #35

Closed OlgaGorlova closed 7 years ago

OlgaGorlova commented 7 years ago

When there are null values, the AVERAGE function gives a wrong result - it uses count of all values including nulls. Instead, it should count only values without nulls.

marcomass commented 7 years ago

@OlgaGorlova Good catch. Does this apply only on AVERAGE or also on other aggregation functions? Did you test all of them (MIN, MAX, MEDIAN, STD, BAG, ...)?

OlgaGorlova commented 7 years ago

@marcomass, should be only on AVERAGE

marcomass commented 7 years ago

@OlgaGorlova Does it mean that you tested all the other aggregation functions and they work correctly also in presence of nulls?

OlgaGorlova commented 7 years ago

@marcomass Yes, I tested them and they are working ok, but I did it on a small synthetic data.

Erlaad commented 7 years ago

Isn't this a partial duplicate of issue #14 ? If so, I tested and found it working (and reported on related issue).