DEIB-GECO / GMQL

GMQL - GenoMetric Query Language
http://www.bioinformatics.deib.polimi.it/geco/
Apache License 2.0
18 stars 11 forks source link

Adjacent #69

Closed eirinistam closed 7 years ago

eirinistam commented 7 years ago

We want the distance from the regions to be equal to 0, to have this result we select DGE(0), DLE(0), but the result of the query is empty (I enclose the query and the input datasets.)

query: DS1= SELECT()adj_1; DS2= SELECT()adj_2; RES = JOIN(DGE(0), DLE(0); output:RIGHT) DS1 DS2; Inputs: https://www.dropbox.com/sh/td5txmqmb8vhsc9/AAAJdIZ4o32jYU_rsyfdBEw5a?dl=0

andreagulino commented 7 years ago

Looking at the implementation, DGE and DLE are actually implemented as > and <, so to get distance = 0, as a temporary solution, you could use DGE(-1), DLE(1).

Let me know if it works, so to confirm what I said I will then change the implementation

@eirinistam @marcomass

as a side node, this is the line of code that implements the check on distance

val intersect_distance = (!firstRoundParameters.max.isDefined || firstRoundParameters.max.get > distance) && (!firstRoundParameters.min.isDefined || firstRoundParameters.min.get < distance)

eirinistam commented 7 years ago

With DGE(-1), DLE(1) I have compiled error. @andreagulino @marcomass

marcomass commented 7 years ago

@andreagulino The distal conditions described in the documentation are the following:

@pp86 Please, add at compiler level also the following cases:

andreagulino commented 7 years ago

@marcomass @pp86 you could just change the compiler so that the instantiated AtomicCondition(s) are like this: DL(n) or DIST <n -> DistLess(n) DLE(n) or DIST <=n -> DistLess(n+1) DG(n) or DIST > n -> DistGreater(n) DGE(n) or DIST >= n -> DistGreater(n-1)

and the issue can be closed

pp86 commented 7 years ago

I Implemented the option proposed by @andreagulino in the last message.

marcomass commented 7 years ago

@lucananni93 @Sim1Pall8a Please update accordingly the Python library and R package

Sim1Pall8a commented 7 years ago

already fixed

lucananni93 commented 7 years ago

fixed