DEIB-GECO / GMQL

GMQL - GenoMetric Query Language
http://www.bioinformatics.deib.polimi.it/geco/
Apache License 2.0
18 stars 11 forks source link

ORDER() compiler error message #98

Closed marcomass closed 6 years ago

marcomass commented 6 years ago

@pp86 For properly working, in ORDER() at least an ordering metadata attribute or a region_order clause must be specified. If this is not the case, now a cryptic error message "None.get" is shown. Please provide meaningful error for the user (e.g. "Ordering metadata attribute or region_order clause must be specified"). Please consider all cases, such as:

marcomass commented 6 years ago

@pp86 Ok. But in the error message there is a typo: "at leat" -> "at least". Please fix. Sorry, I reopen just not to forget.

In addition, I noticed that in the example: D = SELECT(region: chr == chr1) Example_Dataset_1; RES1 = ORDER(pippo; meta_top: 50) D; # cell_karyotype MATERIALIZE RES1 INTO order_0; when the specified metadata ordering attribute is not present in any of the input samples, an empty output is generated. Is this correct?

If so, we need to add a note in the documentation about this case @sunbrn